Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simd: riscv: implement RVV intrinsics #9731

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

cosmo0920
Copy link
Contributor

@cosmo0920 cosmo0920 commented Dec 16, 2024

In RISC-V intrinsics, RVV (RISC-V "Vector") extensions are existing.
In this PR, I experimented to implement RVV extensions and got succeeded to pass internal and runtime tests with turning on this RVV extensions.
This PR uses RVV v0.11 intrinsics.

Some of the RVV extensions are not corresponding one-by-one to NEON or SSE2.
Plus, vuint8m1_t and vuint32m1_t types do not have fixed size.
So, I assumed the fixed lengths for them is 16 like as the result of sizeof(__m128i) or sizeof(uint8x16_t).

Also, we define that FLB_SIMD_VEC8_INST_LEN macro as an emulation for aligned behavior against SSE2 or NEON.
For non-RVV, it just replaces with sizeof(flb_vector8). However, in RVV, gcc complains that there is no sized attributes for vuint8m1_t type.
So, we define the alternative fixed size to determine the length of RVV's instruction set.


Enter [N/A] in the box, if an item is not applicable to your change.

Testing
Before we can approve your change; please submit the following in a comment:

  • Example configuration file for the change
  • Debug log output from testing the change
  • Attached Valgrind output that shows no leaks or memory corruption was found

If this is a change to packaging of containers or native binaries then please confirm it works for all targets.

  • Run local packaging test showing all targets (including any new ones) build.
  • Set ok-package-test label to test for all targets (requires maintainer to do).

Documentation

  • Documentation required for this feature

Backporting

  • Backport to latest stable release.

Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.

@cosmo0920 cosmo0920 force-pushed the cosmo0920-implement-rvv-intrinsics branch from 6c44d3e to 7528308 Compare December 18, 2024 02:12
@cosmo0920 cosmo0920 force-pushed the cosmo0920-implement-rvv-intrinsics branch from 7528308 to 7c5c3bc Compare December 18, 2024 02:17
@cosmo0920 cosmo0920 force-pushed the cosmo0920-implement-rvv-intrinsics branch from 7c5c3bc to 2b094f5 Compare December 18, 2024 05:06
include/fluent-bit/flb_simd.h Outdated Show resolved Hide resolved
src/flb_utils.c Outdated Show resolved Hide resolved
This is because RVV's instruction set is not having a fixed length.
Instead, RVV needs to specify the VLEN for the width of vectorized
calcucaltion.
In this case, we assumed as 128 for VLEN.

Signed-off-by: Hiroshi Hatake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-package-test Run PR packaging tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants